<html>
<head><meta charset="utf-8"><title>cargo vendor · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html">cargo vendor</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220175197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220175197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220175197">(Dec 16 2020 at 21:26)</a>:</h4>
<p>I was just updating our vendor directory for fuchsia and I noticed that cargo vendor dropped all the permissions flags in the process. Is this intentional?</p>



<a name="220176482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220176482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220176482">(Dec 16 2020 at 21:38)</a>:</h4>
<p>Is this a change from previous versions?</p>



<a name="220179100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220179100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220179100">(Dec 16 2020 at 22:00)</a>:</h4>
<p>I do not think so, looking at the git history it has always done it. This is the first time I've seen it, though, that I can recall.</p>



<a name="220183727"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220183727" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220183727">(Dec 16 2020 at 22:40)</a>:</h4>
<p>I would expect <code>cargo vendor</code> to respect umask, if that helps.</p>



<a name="220187590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220187590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220187590">(Dec 16 2020 at 23:20)</a>:</h4>
<p>The specific issue here is that in the past, someone vendored crates with +x. Now, when I run vendor again, those +x bits are stripped. The files are otherwise unchanged.</p>



<a name="220187647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220187647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220187647">(Dec 16 2020 at 23:21)</a>:</h4>
<p>How they got into the repo with +x is a mystery. Some of the files are .sh, which might be expected to have +x set. Others are Rust source files, where you wouldn't.</p>



<a name="220187693"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220187693" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220187693">(Dec 16 2020 at 23:21)</a>:</h4>
<p>That said, if the published crate had a file with +x, I think that the vendored version should too</p>



<a name="220187762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220187762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Rob Tsuk <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220187762">(Dec 16 2020 at 23:22)</a>:</h4>
<p>I might file an issue about it, if I get my head better wrapped around what I'd expect to happen.</p>



<a name="220193001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/cargo%20vendor/near/220193001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/cargo.20vendor.html#220193001">(Dec 17 2020 at 00:27)</a>:</h4>
<p><span class="user-mention" data-user-id="372231">@Rob Tsuk</span> we did have a fix awhile back (maybe 5-6 versions of rustc?) where we always extract a pristine copy of the tarball when vendoring. Previously we'd vendor whatever was in <code>~/.cargo/registry</code> which sometimes had accidental changes, so maybe someone accidentally <code>chmod +x -R $HOME/.cargo/registry</code> and then vendored? Just a wild guess though</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>